search

WowRarity / Rarity

Collectibles and statistics tracking addon for World of Warcraft
https://www.curseforge.com/wow/addons/rarity
GNU General Public License v2.0
55 stars 35 forks source link

Items that can be obtained in zones consisting of multiple subzones aren't displayed correctly in the UI #283

Open rdw-software opened 3 years ago

rdw-software commented 3 years ago

Source: https://github.com/SacredDuckwhale/Rarity/issues/70

There's two subzones in Magister's Terrace, the second of which contains the boss that drops the Swift White Hawkstrider mount. In the UI, both should be recognized as the "current zone", regardless of which one is actually the player's current zone.

This will require a cleanup of the GUI module, at least in part, before tackling it becomes even remotely feasible. Right now it's too much of a headache, so this is put on hold until https://github.com/SacredDuckwhale/Rarity/issues/282 is completed.

rdw-software commented 3 years ago

I've also just noticed this problem occurs with the WOD garrison, where it causes the relevant mounts to not be displayed nor highlighted in the main garrison zone.

Example: Riding Turtle - This item is correctly highlighted in Lunarfall Excavation (579), but not in Lunarfall (582) itself.

In order to fix it, the zone detection code needs to be extended and the GUI needs to be modified, which is currently too difficult. Refactoring the latter is a WIP (https://github.com/WowRarity/Rarity/pull/329). When that PR is complete tackling this might finally be feasible.

rdw-software commented 3 years ago

There's also a zoneOverride property that can be used to override the displayed text. Unfortunately, it doesn't change the highlighting issues, but perhaps this idea can be integrated here to create a better system.