WowRarity / Rarity

Collectibles and statistics tracking addon for World of Warcraft
https://www.curseforge.com/wow/addons/rarity
GNU General Public License v2.0
55 stars 35 forks source link

Riding Turtle mount as drop from Garrison murlocs is not being tracked #44

Open rdw-software opened 6 years ago

rdw-software commented 6 years ago

To be clear: It is being tracked from fishing nodes, but Rarity does not support two different methods for a single item. Therefore, the NPC being killed will not add attempts for this item despite being able to drop it.

rdw-software commented 5 years ago

I also just noticed that the Strand Crawler pet isn't tracked either. At some point, it was, though, as I still have an abandoned entry in my saved variables... weird?

rdw-software commented 1 year ago

This could be resolved by adding custom code (similar to the various world objects/chests) for fishing, then using NPC mode in the DB. It's not very elegant, but it's also easy to implement via copy/paste. A better (more advanced) option would be to also allow a table value as the method field and then iterate over all methods. However, that might cause issues depending on how the other fields are used?