WowRarity / Rarity

Collectibles and statistics tracking addon for World of Warcraft
https://www.curseforge.com/wow/addons/rarity
GNU General Public License v2.0
55 stars 35 forks source link

Add new collectibles for patch 9.2 #462

Closed rdw-software closed 2 years ago

rdw-software commented 2 years ago

Not much to add this time around...

Mounts

Likely relevant:

Source: https://ptr.wowhead.com/items/miscellaneous/mounts?filter=82;2;90200

Most of the mounts are listed as crafting mounts ("Progenitor Synthesis"); I skipped all them. Raid mounts might be guaranteed, so no idea if they'll need to be added yet.

Pets

Likely relevant:

Seems there isn't anything here, really, but maybe I misread the wowhead info.

Source: https://ptr.wowhead.com/battle-pets?filter=3;2;90200

Toys

Likely relevant:

TBD:

Source: https://ptr.wowhead.com/items/miscellaneous/other?filter=216:82;1:2;0:90200

Meta

rdw-software commented 2 years ago

Not sure about the Torghast one, but it's probably best to get the changes merged ASAP and add to it later.

lgkern commented 2 years ago

https://ptr.wowhead.com/item=188700/sturdy-silver-mawrat-harness

Is from the last boss of the run or the boss from Adamant Vaults only.

Raid mounts are all guaranteed.

You're also missing https://www.wowhead.com/item=187676/deepstar-polyp, which is similar to Sundancer, high chance if you're the one summoning Hirukon, low chance if you are just tagging along for the kill.

rdw-software commented 2 years ago

Thanks! I had originally considered the polyp, but since wowhead comments claimed it was a guaranteed drop I then removed it from the list. There seems to be conflicting information and I don't know what to make of it.

If it is indeed a rare drop it could be added, but there's no way to differentiate between attempts with high vs those with low chance. I suppose the best solution would be to set it to a low drop chance, and add a comment that the chance is much higher if you're the one who summoned it?

rdw-software commented 2 years ago

As for the mawrat, wowhead currently lists only one NPC (https://www.wowhead.com/npc=171422/arch-suppressor-laguas). If it can also drop from other bosses I'd need to know which NPCs to add.

Perhaps @godejord knows which of the other NPC IDs should be added? I don't know much about Torghast, unfortunately.

rdw-software commented 2 years ago

I'll publish this in its current state, as it should be useful enough and there's no point in making people wait even longer. If there are some issues, we can address them as they come up :)

lgkern commented 2 years ago

As for the mawrat, wowhead currently lists only one NPC (https://www.wowhead.com/npc=171422/arch-suppressor-laguas). If it can also drop from other bosses I'd need to know which NPCs to add.

Perhaps @godejord knows which of the other NPC IDs should be added? I don't know much about Torghast, unfortunately.

You can add the bosses listed here: https://www.wowhead.com/guides/adamant-vaults-torghast-traps-bosses-rewards-strategy and the three bosses listed here https://www.wowhead.com/guides/adamant-vaults-torghast-traps-bosses-rewards-strategy#bosses-in-the-adamant-vaults

lgkern commented 2 years ago

Thanks! I had originally considered the polyp, but since wowhead comments claimed it was a guaranteed drop I then removed it from the list. There seems to be conflicting information and I don't know what to make of it.

If it is indeed a rare drop it could be added, but there's no way to differentiate between attempts with high vs those with low chance. I suppose the best solution would be to set it to a low drop chance, and add a comment that the chance is much higher if you're the one who summoned it?

When you summon it with the rare lure, the drop rate is 100%,so probably worth just adding the low chance (which seems to be really low from observations)

Watched around 1000 people killing it and saw only 3 drops that weren't increased drop rate. So probably 1:200 if not lower,but early to tell.

rdw-software commented 2 years ago

Strange Goop added in af4da7b, and more NPCs for the mawrat in a58d435. I'm currently investigating a bug with the chest detection, but I'll publish a new release after that is done (or when I run out of time to look into it) so those changes should be live soon-ish :)

lgkern commented 2 years ago

@Duckwhale You can copy the list of NPCs for Gilded Darknight and Maw Stalker for the mount, that should cover all Torghast bosses.

rdw-software commented 2 years ago

Thanks, I added three missing NPC IDs in 614195c :)