Replace read array with for loop

wowu / docker-rollout

🚀 Zero Downtime Deployment for Docker Compose

https://github.com/Wowu/docker-rollout

MIT License

2.37k stars 66 forks source link

Replace read array with for loop #18

Closed yaphet17 closed 9 months ago

yaphet17 commented 10 months ago

This change resolves an issue readarray: command not found in macOS. Since macOS uses an old version of bash, some commands aren't supported including readarray.

klevo commented 10 months ago

This is indeed useful for working on macOS (Sonoma). Thanks @yaphet17

yaphet17 commented 10 months ago

@Wowu What do you think about this PR?

wowu commented 9 months ago

Thanks @yaphet17! Let me test it, fix shellcheck, and it's good to go.

klevo commented 9 months ago

Thanks @Wowu 🎉