remove SC2086 check as it is not very helpful and should be human decided (as you noticed)

wowu / docker-rollout

🚀 Zero Downtime Deployment for Docker Compose

https://github.com/Wowu/docker-rollout

MIT License

2.37k stars 66 forks source link

remove SC2086 check as it is not very helpful and should be human decided (as you noticed) #24

Closed Morriz closed 7 months ago

Morriz commented 7 months ago

Just my 2 cents

wowu commented 7 months ago

Thanks for the suggestion. I really like this check despite the verbosity of ignore comments, as it prevented many errors related to word splitting, at least for me.

I think adding ignore comments with en explanation makes the script somewhat more maintainable, and ensures we quote variables in every place we should.

Morriz commented 7 months ago

when it needs more comments than quotes something is wrong imo ;)