search

WowzaMediaSystems / webrtc-examples

WebRTC Examples
https://www.wowza.com/developer/webrtc/dev-view-publish
BSD 3-Clause "New" or "Revised" License
118 stars 43 forks source link

Framerate changes not applying #11

Closed edgarmcbee closed 4 years ago

edgarmcbee commented 4 years ago

constraintsChanged doesn't seem to switch to true when frame rate changes.

Frame rate changes do apply when a different resolution is chosen.

edgarmcbee commented 4 years ago

Frame rate passed through query parameters is ignored and defaults to 30, the field populates correctly though.

akeller commented 4 years ago

Hey there! WebRTC uses variable frame rate, so this isn't really a bug, but it is a little misleading. I believe on previous version of a similar page we put some language in about this and we are looking to get that back in to help set the expectation that it's variable.

edgarmcbee commented 4 years ago

Could we not apply constraints on change similar to changing the video resolution?

akeller commented 4 years ago

Unfortunately not in the way we are handling it. We don't fail or apply strict enforcement of frame rates.

edgarmcbee commented 4 years ago

Would it make sense to remove the fps input field as it currently serves no purpose?

akeller commented 4 years ago

I'm not sure if this is inflight future work to handle it, but I'll bring this up with the product manager.