search

WowzaMediaSystems / webrtc-examples

WebRTC Examples
https://www.wowza.com/developer/webrtc/dev-view-publish
BSD 3-Clause "New" or "Revised" License
119 stars 43 forks source link

failure tolerance #16

Open crsepulv opened 4 years ago

crsepulv commented 4 years ago

Is your feature request related to a problem? Please describe. If there is a network error and the publisher lost connection it need to recover, right now it stop sending data. Describe the solution you'd like On every network or peer conection error try to reconect.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. on src/lib/WowzaPeerConnectionPublish.js line 147:

if (msgStatus != 200) {
  stop();
  errorHandler({message:msgJSON['statusDescription']});
 start(); //To start again
}

As I understand this is not the only piece of code where the communication could fail, it's need that this client be robust and fail tolerant.

Additional context Add any other context or screenshots about the feature request here, including if your feature request is for something that is currently a feature in Wowza Streaming Engine or Wowza Streaming Cloud and vice versa.

akeller commented 4 years ago

Are you in our Livestreaming Slack? The #webrtc channel has some subject matter experts that may be able to give you some guidance for this.

These are just examples, so fault tolerance would be a productionalization task and likely out of scope for the internal Wowza team.

crsepulv commented 4 years ago

It would be very helpful to the community of wowza customers if you delivered a robust, fault tolerant SDK, so we wouldn't have to reinvent the wheel over and over again.

What is the purpose of creating an opensource repository if you have no intention of improving it?

akeller commented 4 years ago

This is an example implementation, not an SDK. We do have plans to improve this set of examples, but my comment about fault tolerance being out of scope with this repo still stands.

We do have what I would consider a start to an SDK within these examples, but if we decide to move forward with something like fault tolerance I would prefer we get it into an SDK. Right now this repo is demonstrating non-productionalized publish and play features including screenshare as a starting point for devs. We are actively working to improve this experience as well as considering an SDK.

You are more than welcome to fork this code and help us get a jump start on fault tolerance, but I want to set realistic expectations that the team is not working on fault tolerance at this time.