Split LfSource into a spec and state object - Githubissues

Woyten / tune

Make xenharmonic music and create synthesizer tuning files for microtonal scales.

MIT License

134 stars 6 forks source link

Split LfSource into a spec and state object #34

Closed Woyten closed 2 years ago

Woyten commented 3 years ago

Current situation:

LfSource acts as a specification and as a state object at the same time
When using LfSourceExpr::Envelope the envelope needs to be looked up in a HashMap which seems undesirable in terms of performance

Desired situation:

[x] In the same way that StageSpec and WaveformSpec are separated from Stage and Waveform, LfSource should be split into a spec and state object. Done in 6e9b0fd4b22321eba7bdfdc01294535d2866064f.
[x] Envelopes should be looked up once on waveform creation and be stored in the state object. Done in 0a0b4b70c7e1439a59994c8b359d1726da28b9ea.

Woyten commented 3 years ago

So far, I could not observe any negative performance impact of the envelope look-up.