search

WrathChaos / StompClientLib

Simple STOMP Client library, Swift 3 and 4, 4.2, 5 compatible
https://www.freakycoder.com
MIT License
154 stars 81 forks source link

Adding Objective-C attributes to delegate and main class to turn Objective-C runtime accessible to Nativescript #95

Closed dfborba closed 3 years ago

dfborba commented 3 years ago

Hey Team, we have a project which needs to connect through WebSocket with STOMP protocol for Nativescript applications; But to Nativescript be able to access Swift classes it needs to be able to access the Objective-C runtime. So in order to achieve it I've changed the StompClientLib and added the @objc attribute annotation to StompClientLibDelegate and @objcMembers to StompClientLib, so these classes and its attributes/methods and etc can be access from Nativescript.

Please, review this code and let me know if these changes will not affecting any other project that use this library. Looking forward to have these changes approved 👍 Thanks.

WrathChaos commented 3 years ago

Hello again @dfborba :) Let me check and test it and then I will approve and release a new version :) Great job!

WrathChaos commented 3 years ago

Hi @dfborba, image

I've merged and released a new version (1.4.0).

1.4.0 🥰

Thank you so much for the contribution, can you please also test the new version?

dfborba commented 3 years ago

Amazing @WrathChaos! Will do the tests for sure..

Happy to contribute!