Closed swparkaust closed 4 years ago
Hello @swparkaust Can you try it with npm not yarn?
@WrathChaos I attached logs for both npm and yarn in OP. Seems like it is looking for the expo
branch which is not there.
Oh, you're right. I'm gonna fix it ASAP
Hey again @swparkaust, Can you please try the latest version of the library with the following setup:
"tslib": "^1.11.1",
"@expo/vector-icons": "Kaushald4/vector-icons#master",
"react-native-dynamic-vector-icons": "WrathChaos/react-native-dynamic-vector-icons#expo",
It works on my environment, can you please try it and give me feedback. If it works, I will update the README, otherwise, I need to create an Expo version of the library.
@WrathChaos I created another blank Expo project (SDK 37), did npm i react-native-dynamic-search-bar
(no expo), added above 3 lines from your post to package.json
, and re-did npm install
, which all were successful. (yarn fails here with something mentioning react-native link
which I can't do in a managed Expo project so I just used npm.)
However, if I add the import and try to render the SearchBar
, it either gets stuck at Downloading JavaScript bundle: 100.00%
, or I get Invariant Violation: View config not found for name RCTSinglelineTextInputView
(when running on an iOS device) / AndroidTextInput
(when running on an Android).
The app runs back to normal once I remove the import and any reference to SearchBar
, so I'd assume there must be some incompatibility (with the latest Expo SDK).
Thank you so much @swparkaust, I'm going to make a fresh Expo version tonight :) I hope I can make it in one night.
@WrathChaos Sounds good. Please let me know once it's ready :) Thanks for creating the library, I am going to use it to implement an Apple Map-like bottom sheet for my app and your library looks very promising.
Hi again @swparkaust, I've updated the expo branch :)
"@expo/vector-icons": "Kaushald4/vector-icons#master",
"react-native-dynamic-search-bar": "github:WrathChaos/react-native-dynamic-search-bar#expo",
"react-native-dynamic-vector-icons": "github:WrathChaos/react-native-dynamic-vector-icons#expo",
Please install them and try it :) Also, there is VERY basic example on the 'expo' branch. :)
Waiting for your review to update the documentation.
@WrathChaos It worked, just had to install two more dependencies as in readme: @freakycoder/react-native-helpers
, react-native-vector-icons
.
Works great now in the latest expo.
Ah yes, you need to install them. I will update the README then. Thank you for the feedback :) If you need anything or a new idea, please open an issue and we can make it happen :)
I have followed the readme in a latest expo project and this is what I get:
yarn:
npm: