search

WrathChaos / react-native-dynamic-search-bar

Medium Article: https://freakycoder.com/react-native-library-dynamic-search-bar-c03fea9fae36
MIT License
479 stars 52 forks source link

Documentation: Missing Props #27

Closed WrathChaos closed 4 years ago

WrathChaos commented 4 years ago

Missing Props

tiagostutz commented 4 years ago

Hi @WrathChaos I'd like to contribute with this issue but I couldn't find any CONTRIBUTING docs. Are this contributing docs in progress? Or maybe you need some help with this also? I can help with that too.

What you say?

WrathChaos commented 4 years ago

I don't have a contribution doc because rarely people contribute :) I would love you to help. Let's talk about it sometime

tiagostutz commented 4 years ago

OK!

Do you want me to take this issue here?

surbhitrao commented 4 years ago

I'd love to contribute as well.

WrathChaos commented 4 years ago

Hey guys really sorry for the late response. I was sick :( You can take the issue here, I can edit/change and give you feedback about that. @tiagostutz I would love to take your contribution @surbhitrao :)

tiagostutz commented 4 years ago

@WrathChaos sorry about that! Hope your are doing better now! =)

@surbhitrao do you like to take this issue here? If so, I can pass it to you as I have already made one PR. If not, I will keep for me this issue and will make the PR.

surbhitrao commented 4 years ago

Sure, we can take the issue here.

WrathChaos commented 4 years ago

Hey @surbhitrao, What is going on with this issue? Will you solve it?

tiagostutz commented 4 years ago

If @surbhitrao does not respond, I can take this. Just let me know, @WrathChaos

WrathChaos commented 4 years ago

@tiagostutz, yes please :) I am open for any PR and any idea :)

tiagostutz commented 4 years ago

Nice! I'm searching here for some doc generator and I'm making some testes with https://github.com/marborkowski/react-doc-generator and https://github.com/TypeStrong/typedoc. I don't have experience with "professional" documentation, so if you have any preference, let me know.

WrathChaos commented 4 years ago

Hey @tiagostutz, Actually we do not need a doc generator. The best professional documentation is a manual one :)

tiagostutz commented 4 years ago

So, let's go manual! =)

tiagostutz commented 4 years ago

Can I put the properties in alphabetical order? Or you want to keep the order as it is and I should put the new properties at the end of the table?