WrathChaos / react-native-dynamic-search-bar

Medium Article: https://freakycoder.com/react-native-library-dynamic-search-bar-c03fea9fae36
MIT License
479 stars 52 forks source link

Just Doesn't Work And Contains NODE_MODULES #32

Closed stephanoparaskeva closed 4 years ago

stephanoparaskeva commented 4 years ago

This lib has so many dependencies so i'm not sure where the error comes from. Version: RN 0.62.2 (Non-Expo) Everything at @latest

Screenshot 2020-06-21 at 22 39 32
WrathChaos commented 4 years ago

Hello @stephanoparaskeva, Can you try it on 0.61.5? Also have you ever tested it on a fresh example on 62.2?

stephanoparaskeva commented 4 years ago

Hello @stephanoparaskeva, Can you try it on 0.61.5? Also have you ever tested it on a fresh example on 62.2?

I think this is the issue

Screenshot 2020-06-21 at 22 44 45

Thanks for the quick response btw, really would like to use your work

My command to install was npm i react-native-dynamic-search-bar

WrathChaos commented 4 years ago

I think I have never tested it on 0.62.2. It totally works on 0.61.5 as you can tested on example. I will test it on 0.62.2 now, while I'm doing that can you run this command and test it please:

watchman watch-del-all && rm -rf node_modules/ && npm cache clean -f && npm install && react-native run-ios

stephanoparaskeva commented 4 years ago

I think I have never tested it on 0.62.2. It totally works on 0.61.5 as you can tested on example. I will test it on 0.62.2 now, while I'm doing that can you run this command and test it please:

watchman watch-del-all && rm -rf node_modules/ && npm cache clean -f && npm install && react-native run-ios

I've run that command already, I've fixed the issue now but as I'm saying:

The issue is that you are exporting Node_modules in your build. The package is installed and contains node_modules, which it should not.

WrathChaos commented 4 years ago

@stephanoparaskeva You're right :) I forgot the dependency part into the library. Thank you to awake of that.

Can you please check this version:

1.2.1

stephanoparaskeva commented 4 years ago

@stephanoparaskeva You're right :) I forgot the dependency part into the library. Thank you to awake of that.

Can you please check this version:

1.2.1

Awesome this works great with RN 0.62.2 🚀