Support Vietnamese - Githubissues

WrathChaos / react-native-time-date-picker

🚀 Easy to use time and date picker with lots of options for React Native 🥳

https://freakycoder.com

MIT License

35 stars 7 forks source link

Support Vietnamese #11

Closed tri2820 closed 1 year ago

WrathChaos commented 1 year ago

Hello @tri2820

In this PR, there are 68 file changes and the PR's title is just support Vietnamese. Can you please clean it up?

WrathChaos commented 1 year ago

@tri2820 I believe all you need are

lib/utils/translations/index.ts
lib/utils/translations/vi.ts

these files, if you believe we need other changes as well you should open up another PR for these and explain, please :)

Also, we should not have build/dist folders and files because these should be generated

tri2820 commented 1 year ago

Sure, I built the files and committed them accidentally. Other than the 2 files however there is a fix needed to make Vietnamese work - I will create a PR and explain there.

WrathChaos commented 1 year ago

@tri2820 You should open another PR for the fixes then :)