Wren6991 / Hazard3

3-stage RV32IMACZb* processor with debug
Apache License 2.0
696 stars 47 forks source link

Nits: JTAGG -> JTAG #9

Closed secworks closed 11 months ago

secworks commented 11 months ago

There is a minor spelling in the file: "JTAGG" should be "JTAG".

https://github.com/Wren6991/Hazard3/blob/e8b4578b4003d838f006dca00b5fea5852e4ab98/example_soc/fpga/fpga_ulx3s.f#L9C48-L9C53

Wren6991 commented 11 months ago

Nope, that is the correct name of that ECP5 primitive

https://github.com/Wren6991/Hazard3/blob/e8b4578b4003d838f006dca00b5fea5852e4ab98/hdl/debug/dtm/hazard3_ecp5_jtag_dtm.v#L6

See notes here: https://github.com/tomverbeure/ecp5_jtag

Wren6991 commented 11 months ago

It's a bit of an unfortunate name, but if you've already had JTAGA through JTAGF then what follows is inevitable.

secworks commented 11 months ago

Ah, my mistake, sorry.