search

WrenSecurity / wrensec-guice

Common Guice implementation used by Wren Security forks of ForgeRock projects.
http://wrensecurity.org
0 stars 3 forks source link

Deprecate this project and merge it with Wren:AM #4

Open pavelhoral opened 3 years ago

pavelhoral commented 3 years ago

AFAIK this project is only used by Wren:AM (needs verification). If so, there is no need to actually have it as a separate project and it can be part of Wren:AM as its own submodule or as part of openam-core module. This is similar effort to merging OSGi launcher to Wren:IDM - https://github.com/WrenSecurity/wrenidm/issues/77.

pavelhoral commented 3 years ago

When migrating, we should also revert the PRODUCTION stage back to DEVELOPMENT. In the context of Wren:AM it really does not make much sense as that breaks quite a lot of unit tests (see XXX comments and setupGuice methods).

https://github.com/WrenSecurity/wrensec-guice/blob/master/CHANGELOG.md

pavelhoral commented 2 years ago

AFAIK this project is only used by Wren:AM (needs verification).

Unfortunately this project is used from wrensec-commons - https://github.com/WrenSecurity/wrensec-commons/blob/master/http-framework/http-servlet/src/main/java/org/forgerock/http/servlet/HttpApplicationLoader.java#L199 .

However that does not rule out merging this project with Wren:AM. It only means that the mentioned HttpApplicationLoader needs to move to Wren:AM as well.