search

WrightonLabCSU / DRAM

Distilled and Refined Annotation of Metabolism: A tool for the annotation and curation of function for microbial and viral genomes
GNU General Public License v3.0
239 stars 50 forks source link

bug in `v.1.5.0` on the `DRAM-setup.py` help message #334

Open hariszaf opened 4 months ago

hariszaf commented 4 months ago

Hi DRAM community.

I just noticed that there is a bug in DRAM 1.5.0 release on the DRUM-setup.py script.

Here is the issue: https://github.com/WrightonLabCSU/DRAM/blob/7735a04e58c300d53f9d3611a583b48e507bb843/scripts/DRAM-setup.py#L123C6-L126C66

as you can see there are two help messages and a missing parenthesis.

It seems that in the master branch you have already fixed that.

Thanks for the great effort and hope this helps!

fischuu commented 1 month ago

Hi,

actually, I believe that bug is critical, as it is also present in the current bioconda 1.5.0 release making it impossible to setup the databases with the current version.

A workaround is to fix the script in the conda env and just add the parenthesis and remove the additional help message.