search

Wruczek / Bootstrap-Cookie-Alert

A simple, good looking cookie alert built for Bootstrap 3/4. No dependencies required.
https://wruczek.github.io/Bootstrap-Cookie-Alert/demo-bs5.html
MIT License
240 stars 50 forks source link

Feature request: Semi-standalone version? #5

Closed LarsGMortensen closed 5 years ago

LarsGMortensen commented 6 years ago

Most sites (at least most of my sites) already have jQuery implemented for various other functionality. But they don't have jsCookie.

Would it be possible to make a semi-standalone-version that is dependent on jQuery, but is standalone in regards to jsCookie ...?

Thanks a lot!

AndiLeni commented 6 years ago

In the repository is already a standalone version that does not rely on jscookie.

Wruczek commented 6 years ago

Actually, I was thinking about removing the dependency version all together and leaving just the vanilla implementation. We use so little jQuery in the dependency version that it doesn't benefit us in any real way, and having 2 separate scripts doing the same is (I feel like) not needed at this point. + it creates confusion (#2)

I think that having just the vanilla version + vanilla minified would be the best option.

ghost commented 5 years ago

@Wruczek I'd remove the dependency version, it's 700B smaller than the vanilla implementation.

Wruczek commented 5 years ago

Yep I think that's a good move. I will push an update and remove the dependency version.