Longer hostnames cause wrapping issues in Server status

ShadyShell commented 5 years ago

I would prefer to give my users a URL rather than an IP address to connect to, however my domain name is rather long and I run into the issues pictured in the screenshots below.

Normal: screenshot_3

Longer hostnames: screenshot_2 screenshot_1

Wruczek commented 5 years ago

Thanks for reporting! It's a very specific bug that probably affects small number of ts-website installations.

1.0 is kinda in the end-of-life state right now, so i think I will leave it as wontfix for 1.0. But I've added a fix for it in 2.0 (that I hope is coming out soon).

Until 2.0 is out, I think removing the word "Address" and putting the address on the left might be a good solution.

To make this change:

Find the line with address (include/header.php line 142): https://github.com/Wruczek/ts-website/blob/d5a99b430a76d4abe5662de142d2603c091a6ca6/include/header.php#L142

Replace it with:

<p><i class="fa fa-globe fa-fw" aria-hidden="true"></i> <a href="ts3server://<?php echo $config['teamspeak']['displayip']; ?>" style="float: none"><?php echo $config['teamspeak']['displayip']; ?></a></p>

Let me know if that answers it :)

ShadyShell commented 5 years ago

That worked perfectly, thank you very much :). Do you want me to leave this open for tracking on 2.0 or close it?

Wruczek commented 5 years ago

Its already fixed in 2.0 so we can close it.

Wruczek / ts-website

Longer hostnames cause wrapping issues in Server status #95