search

WsdlToPhp / PackageBase

Contains base classes from which the generated classes from PackageGenerator inherit
MIT License
24 stars 26 forks source link

type checking exception raised in php8 #38

Closed maurobn closed 1 year ago

maurobn commented 3 years ago

PR to execute the package in PHP8.

maurobn commented 3 years ago

A tiny adjustment in order to be able to execute the package in php8

codecov-io commented 3 years ago

Codecov Report

Merging #38 (6d96518) into develop (0d2e50c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #38   +/-   ##
==========================================
  Coverage      97.45%   97.45%           
  Complexity       121      121           
==========================================
  Files              5        5           
  Lines            275      275           
==========================================
  Hits             268      268           
  Misses             7        7
Impacted Files Coverage Δ Complexity Δ
src/AbstractStructArrayBase.php 100.00% <100.00%> (ø) 32.00 <6.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d2e50c...6d96518. Read the comment docs.

maurobn commented 3 years ago

Generated classes are children of AbstractStructArrayBase and neither they neither AbastracrStructArrayBase don’t implement ArrayObject, so the exception is raised.

Em 14 de abr. de 2021, à(s) 04:11, Mikaël DELSOL @.***> escreveu:



@mikaelcom commented on this pull request.

In src/AbstractStructArrayBase.phphttps://github.com/WsdlToPhp/PackageBase/pull/38#discussion_r612992645:

@@ -251,15 +251,15 @@ private function getInternArrayOffset(): int

  • @param bool $internCall indicates that methods is calling itself
  • @return AbstractStructArrayBase */
  • private function initInternArray(array $array = [], bool $internCall = false): self
  • private function initInternArray($array = [], bool $internCall = false): self

It's not supposed to be anything else than an array if the class inheriting from it is defined as expected. To be discusssed within the WsdlToPhp/PackageGenerator#248https://github.com/WsdlToPhp/PackageGenerator/issues/248 issue

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/WsdlToPhp/PackageBase/pull/38#pullrequestreview-635280740, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHHMQGMT6RVVGTFMC2WFHL3TIU5ZBANCNFSM424KNGPQ.