search

WsdlToPhp / PackageGenerator

Generates a PHP SDK based on a WSDL, simple and powerful, WSDL to PHP
https://providr.io
MIT License
426 stars 73 forks source link

Failed to execute unzip #166

Closed fridzema closed 5 years ago

fridzema commented 5 years ago

Hello,

Anyone has an idea what this means? 

  - Updating wsdltophp/packagegenerator (3.0.3 => 3.0.4): Loading from cache    Failed to execute unzip -qq  '/Users/rf/workspace/pmp/vendor/wsdltophp/packagegenerator/fe74a9f75cc1acfe86690cb4b72ec034' -d '/Users/rf/workspace/pmp/vendor/composer/08c2d881'

error:  cannot create /vendor/composer/08c2d881/WsdlToPhp-PackageGenerator-ab2db90/tests/resources/generated/Valid?????????????.php
        Illegal byte sequence

    The archive may contain identical file names with different capitalization (which fails on case insensitive filesystems)
    Unzip with unzip command failed, falling back to ZipArchive class
mikaelcom commented 5 years ago

The file name contains cyrillic characters and several files are in the same folder. So if they have the same number of cyrillic characters which are replaced by « ? », it seems to consider the files are duplicated. It’s maybe related to your OS as I don’t have this isssue.

mikaelcom commented 5 years ago

Any progress?

fridzema commented 5 years ago

@mikaelcom thanks for explaining! I have reinstalled my vendor folder and this seems to fix the issue.

binarious commented 5 years ago

Same issue for me. Removing vendor doesn't work. I'm unable to install this package via composer. I don't think using cyrillic characters in the filename is a good idea.

mikaelcom commented 5 years ago

Are you on Windows ? Mac ? Or Unix ?

binarious commented 5 years ago

macOS: 10.14.6, composer: 1.9.0, php: 7.3.7 It works on Debian Buster.

mikaelcom commented 5 years ago

@Gemorroj, any though on this matter ? If I recall right, you're using cyrillic characters :)

binarious commented 5 years ago

The test files aren't required in the composer archive, are they? They could still exist in this repository to run the test suite, but be excluded for composer consumers. Just an idea.

Gemorroj commented 5 years ago

50

Yes, the use of Cyrillic in names is considered very bad form. Perhaps this bug should be addressed to https://github.com/composer/composer Can be noted that on windows all well. Захват-1

mikaelcom commented 5 years ago

50

Yes, the use of Cyrillic in names is considered very bad form. Perhaps this bug should be addressed to https://github.com/composer/composer

Ok so I should rename the files containing Cyrillic to English names :)

binarious commented 5 years ago

Perhaps this bug should be addressed to https://github.com/composer/composer

It's seems to be an issue in unzip:

mikaelcom commented 5 years ago

fixed in 3.2.3 and 2.11.3 :wink: