Remove deprecated message

[Oipnet]

Add the return type for methods :

• ArrayAccess::offsetGet
  • ArrayAccess::offsetSet
  • ArrayAccess::offsetUnset
  • Iterator::current
  • Iterator::next
  • Iterator::key
  • Iterator::rewind
  • Countable::count

[mikaelcom]

What are the deprecated message exactly?

[Oipnet]

Sorry I forgot that it was not avaible for PHP 7.4. I think it was ok.

This is the trace (I use php 8)

2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObj
ectContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObje
ctContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractOb
jectContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::current()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectCo
ntainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::next()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectContai
ner" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::key()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectContai
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::rewind()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectCont
ainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Countable::count()" might add "int" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectConta
iner" now to avoid errors or add an explicit @return annotation to suppress this message.

You can reject this pull request.

[mikaelcom]

Sorry I forgot that it was not avaible for PHP 7.4. I think it was ok.

This is the trace (I use php 8)

2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObj
ectContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObje
ctContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractOb
jectContainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::current()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectCo
ntainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::next()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectContai
ner" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::key()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectContai
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Iterator::rewind()" might add "void" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectCont
ainer" now to avoid errors or add an explicit @return annotation to suppress this message.
2022-03-02T06:58:10+00:00 [info] User Deprecated: Method "Countable::count()" might add "int" as a native return type declaration in the future. Do the same in implementation "WsdlToPhp\PackageGenerator\Container\AbstractObjectConta
iner" now to avoid errors or add an explicit @return annotation to suppress this message.

You can reject this pull request.

Or you simply remove the mixed return type which would be best than nothing. For the mixed, add the @return annotation and it would solve the deprecated messages, no?

[Oipnet]

I remove mixed and add the @return annotation. It seems ok for me.