search

WuTheFWasThat / vimflowy

An open source productivity tool drawing inspiration from workflowy and vim
https://www.wuthejeff.com/vimflowy
MIT License
1.6k stars 111 forks source link

Improve search #336

Closed shady2k closed 5 months ago

shady2k commented 4 years ago

Added parent block and grouping by it. image

shady2k commented 4 years ago

@WuTheFWasThat, can you look at this?

WuTheFWasThat commented 4 years ago

hmm, I'm not really convinced this is a good idea, since the space could be used by more results, and as a document gets a bit bigger most results will be under separate parents.

BTW, search becomes unusable once your document gets long :( and I generally recommend searching by marks instead. Would love to have faster search but it's a bit involved to implement

shady2k commented 4 years ago

But the conclusion without groups is absolutely inconvenient. Especially if you come across the same text in different lines. Maybe make this behavior optional in the settings?

WuTheFWasThat commented 4 years ago

ok sounds good, i'd prefer default off if that's ok. you could add it to either ClientSettings or LocalDocSettings or DocSettings, not sure which one is best

then maybe it works to just change one line to path.parent && setting_is_on ? await session.document.getLine(path.parent.row) : []