Wudji / XPlus-AutoFish

An update of MrTroot's Autofish mod to 1.19.4+ with various new features & bugfixs.
https://modrinth.com/mod/x+-autofish
GNU General Public License v3.0
16 stars 6 forks source link

Feature Request: Re-cast when bobber is stuck at the player's feet #6

Closed GrahamJenkins closed 1 month ago

GrahamJenkins commented 8 months ago

I have noticed that with this mod (and previous versions) sometimes the bobber will be cast and end up at the player's feet. I recently discovered that this is (usually?) clientside after seeing fish swim towards where the marker should be. I am currently working around this with a macro (jsMacros) to detect when a bobber is within 3 blocks of the player, but it's a hack.

I would like to suggest that the re-cast feature also check not only if the bobber has been cast, but if the bobber is either at the player's feet, or not in water.

Also, thank you for picking up this mod and maintaining it, as well as the Modrinth listing. I see that you have it marked as "temporary" but given that it's been a year or two since the last meaningful update of the original autofish, I think it's safe to say that it has been abandoned.

I would like to suggest that you consider a full fork/minor rebrand if you are interested in doing anything more than minor repackaging. (such as the feature request above) I'm sure I am not the only person who has checked for an update to the original auto fish mod over the last year and been disappointed. I imagine I'm in the minority of people who took the time to check the source/issues and realize that somebody had forked it.

Anyways, no pressure, but if you're willing to more officially support this mod, I think it would be a benefit to the community. Thanks again!

Wudji commented 8 months ago

Thank you very much for your valuable feedback and suggestions regarding the XPlus Autofosh mod. Your observations and workaround are indeed insightful, and I appreciate your suggestions on addressing the issue with the bobber casting. I will take this into account when planning future updates.

I would like to inform you that we are currently in the midst of the Chinese New Year celebrations, which is a significant holiday period in China. As such, my ability to delve into the mod's issues, including the one you've mentioned about casting the fishing bobber, will be somewhat limited until the festivities conclude. I fully intend to investigate and attempt to resolve the problem as soon as the holiday period is over.

Regarding the mod's name, I have renamed it to XPlus Autofish to differentiate it from the original version. This is to avoid any confusion and to clarify that this is a separate iteration with its unique updates and potential improvements.

Once again, thank you for reaching out and for your support.

Wudji commented 1 month ago

In v1.3.0, the persistentMode will check whether the bobber is in water. If not, it will automatically reel in and recast, which should fix this issue. v1.3.0 will be released for Fabric 1.19.4-1.21.1, Forge 1.20.1-1.19.4, NeoForge 1.21 soon.

Thank you for reaching out and sorry for the late fix~