search

Wuild / GatherLite

World of Warcraft: Classic Gathering addon keeping track on where you have found stuff
MIT License
32 stars 16 forks source link

Addon conflicts with Minimap Button Bag (MBB) addon #74

Closed Maczuga closed 5 years ago

Maczuga commented 5 years ago

Describe the bug When GatherLite is enabled together with MBB - every movement try generates a 2sec lag. Also it floods the MBB with vein/herb icons (see screenshot).

To Reproduce Steps to reproduce the behavior:

  1. Install MBB addon from here: https://www.curseforge.com/wow/addons/mbb
  2. Launch the game with GatherLite and MBB enabled
  3. Game lags whenever a character moves and MBB is filled with GatherLite icons

Expected behavior Icons should remain on minimap and should not be causing the lag when combined with MBB.

Screenshots image

Additional context There was a similar problem with Questie addon, however it's fixed in it's 4.1.0 version, might be worth checking. Looks like that's the commit: https://github.com/AeroScripts/QuestieDev/commit/b5743424842d8ce47c33c2ea0bdbdbf9d5c43d58 Disabling GatherLite prevents the icon spam and lag.

Wuild commented 5 years ago

this has been fixed

Maczuga commented 5 years ago

Still occurrs, but only in special condition:

  1. Toggle addon off by Shift-click the mini-map icon.
  2. /reload
  3. Toggle addon on - no icons in MBB (works fine here).
  4. /reload
  5. Addon is on, icons are back in MBB, lag is here too.
Maczuga commented 5 years ago

@Wuild I don't know if you have seen this. This issue needs to be reopened. Also with the recent version - lag still occurrs when using with MBB.

Wuild commented 5 years ago

I was missing the MBB dep. please try version 1.3.0 as it is working for me.

Maczuga commented 5 years ago

@Wuild I am using 1.3.0,

Those are my settings: image

If I enable the GatherLite via Shift-clicking the minimap icon and /reload - lag is back. Also you can see there is 1 Mithril Ore icon in my MBB.

Also with last 2 options checked I still get lots of ore icons in MBB + even bigger when I try to move my character (see below).

image

Wuild commented 5 years ago

hmm wierd... ill have a look at it

Wuild commented 5 years ago

ah! it's been fixed, ill publish a new release soon