general cleanup and maintenance

Wulf / create-rust-app

Set up a modern rust+react web app by running one command.

https://create-rust-app.dev

Apache License 2.0

1.54k stars 63 forks source link

general cleanup and maintenance #362

Closed AnthonyMichaelTDM closed 6 months ago

AnthonyMichaelTDM commented 12 months ago

changed StatusCode from i31 to u16.
refactored logic
expanded documentation
added TODOs
made some functions more generic (to improve API w/o causing breaking changes)

this is just a start, there's a lot of TODOs I still need to tackle as well

Wulf commented 11 months ago

Whao! Thanks for taking the time to do this.

Let's do this MR as usual, but going forward, it'll be much easier for me if we have smaller-sized changes! I know it's hard sometimes, especially when we combine everything from a working session into a single MR, but it makes it easier for me as I don't have all the time in the world (that way we can maintain shipping velocity!). I hope you understand :)

🤗

AnthonyMichaelTDM commented 11 months ago

sure, I can have this as base then do subsequent PR's to address the TOOD's and whatnot

AnthonyMichaelTDM commented 7 months ago

I forgot why I hadn't merged this yet, it's been a while... I plan on looking over it again soon though

AnthonyMichaelTDM commented 6 months ago

Okay I think it's good now, gonna do one final review before I merge though