search

Wulfheart / laravel-actions-ide-helper

MIT License
18 stars 26 forks source link

Support mixins method #12

Closed innocenzi closed 8 months ago

innocenzi commented 2 years ago

https://github.com/barryvdh/laravel-ide-helper supports the -M flag, that will create class names like IdeHelperAircraftType instead of AircraftType.

It would be super nice for this package to support that as well, because right now, following the symbols for an action class lead to the IDE helper file instead of the actual action (on VSCode at least, I assume PHPStorms handles that correctly).

Basically, this flag would:

Wulfheart commented 2 years ago

Nice idea. Feel free to open a PR. 👍🏻

innocenzi commented 2 years ago

Cool! I took a spin at it and I easily managed to generate the correct class names, but I don't know yet how to update the action files. I'll see when I have a bit more time.

Wulfheart commented 2 years ago

Take a look at BuildIdeHelper. Maybe this gives you a little guidance.

vpratfr commented 1 year ago

+1 on this one as this would make the resulting code more PHPStan friendly :)

Wulfheart commented 1 year ago

Ok. Time is scarce right now. A PR would definitely help.

innocenzi commented 1 year ago

FYI I'm no longer using this package so I will not be able to make this PR.

Wulfheart commented 1 year ago

To be honest this package could be considered unmaintained as well. It would be nice to find a maintainer. Unfortunately, I rarely use Laravel Actions anymore.

vpratfr commented 1 year ago

@Wulfheart I don't have much time either for new features, but I would be ok to review some PR and make new releases. We are using the package in a recent project at work, hence I should be monitoring at least Laravel updates.

Let me know if you would like some help to get small PRs such as L10 compat merged in new versions quickly.

I authored and maintain a couple of Laravel packages too (https://github.com/marvinlabs/laravel-luhn for instance)

Wulfheart commented 8 months ago

This project is in YOLO-mode now. Please feel free to re-open if you think it still applies.