Wulfheart / laravel-actions-ide-helper

MIT License
17 stars 26 forks source link

Php 8.1 intersection types don't work #4

Closed brecht-vermeersch closed 8 months ago

brecht-vermeersch commented 2 years ago

This

public function handle(Permissionable&Model $permissionable): Permission

Produces

Wulfheart commented 2 years ago

This might be true. Haven’t had the time to take a look at it. Would you be willing to work on it with some guidance?

brecht-vermeersch commented 2 years ago

Hi Wulfheart

I've looked through the project files and already found some areas I could improve on (if you give me permission to do so).

If you give me the go ahead on any of these features, I will start looking into them.

Wulfheart commented 2 years ago

Hey @lurza, that would be great. I would really appreciate it if you could start by adding tests first and the rest after that. I currently have limited time due to the nearing end of my bachelor's degree but I will take the time and review it. Furthermore I will add an GitHub Action for the tests to run automatically on Push and PR.

Wulfheart commented 2 years ago

@lurza I just published a new version but I think it is failing right now. Feel free to take a look at it. I would really appreciate it!

Wulfheart commented 8 months ago

This project is in YOLO-mode now. Please feel free to re-open if you think it still applies.