search

Wumpf / IncludeToolbox

Visual Studio extension to format, prune, and inspect include directives.
https://marketplace.visualstudio.com/items?itemName=Wumpf.IncludeToolbox
MIT License
51 stars 22 forks source link

fixes issue #36 #59

Closed codingdave closed 6 years ago

codingdave commented 6 years ago

This fix uses a support file to pass to include-what-you-use.exe. Long argument lists happen to not be supported.

codingdave commented 6 years ago

Hi, I went into the same problem like discussed in #36 and fixed it using support files.

Wumpf commented 6 years ago

didn't think of trying support/response files to fix those issues, didn't look like too long command line to me. But if that solves it, sure 🤷‍♀️ Please address the mentioned issues and come up with a better commit message ;)

codingdave commented 6 years ago

For us this reliably solves the issue. I may even want to promote some more flags for use of VS. It would be also very interesting for us if someone had a msvc imp file (the one I downloaded on the IWYU github does not do a good job for us).

I dont understand how I can improve my commit message. Any guidelines for that?

Kind regards

codingdave commented 6 years ago

I have created a new PR #60 with a reworked commit, hopefully better commit message, no Regex.Escape and still using support files for fixing the bug many users have.

I would be happy for any kind of feedback.

Cheers, Dave