Some menu labels are colored differently than others

Wumpf / VSSolutionColor

Visual Studio extension to change title bar color depending on the current solution

41 stars 18 forks source link

Some menu labels are colored differently than others #19

Open austindavenport opened 5 years ago

austindavenport commented 5 years ago

Please see posted screenshot.

The "Project", "Build", and "Test" menu item labels are colored white against an orange background (RGB 255, 128, 0) while the remaining menu item labels are colored black. Changing the color to a slightly different orange (RGB 255, 128, 64) temporarily fixes it, but after a computer restart, the issue happens again and I have to switch back to the original orange color (RGB 255, 128, 0).

austindavenport commented 5 years ago

After restarting my computer and opening Visual Studio, the menu label colors are correct, so I do not know what the cause is. I do know that I see this issue occur when I come into work in the morning.

Wumpf commented 5 years ago

Huh, really odd. Haven't seen this yet. Let me know when you get a repro again

austindavenport commented 5 years ago

I got the issue again this morning. Here is what I did and what conditions were used:

Visual Studio 2019 (I should have mentioned this earlier)
I clicked on the "Continue without code" link at the bottom-right of the welcome screen
I opened the solution in the "Recent Projects and Solutions" submenu
The solution contains all (if not mostly) WPF projects
The color I assigned to this solution is standard orange (RGB 255, 128, 0)
The same exact menu labels are white as in the attached screenshot (Project, Build, and Test)
While the solution was opening, all menu labels were black for a few seconds until the three I mentioned turned white

EDIT: added last bullet point

austindavenport commented 5 years ago

The issue definitely seems to happen when I load a solution via the "Recent Projects and Solutions" submenu in the File menu. It doesn't happen when I click a recent solution on the left side of the welcome screen directly. Also, I changed the solution color titlebar to white and the same three menu labels are colored white (even against a white background).

JimRiedemann commented 3 years ago

It appears to me that SolutionColor only repaints the menu choices that exist when it initializes, but any menu items added after that point remain in the original color. This seems to happen for me on the first open-project event after a VS startup. In that case, SC initializes, then VS adds the Build menu and others which are not altered.

Repro steps (VSE 16.10.3):

Start a clean copy of VS with SC installed.
Use either File\Open or Recent Projects and Solutions to open a solution that has previously been configured with a different color in SC.
As VS works to open the solution, the title bar will change color, along with all visible menu items.
As VS finishes opening the solution, it adds the Project, Build, and Test menus in their original color.
Closing the solution and re-opening it, or selecting a color in SC, resets the rest of the menu choices to the SC foreground color.