search

Wunderbyte-GmbH / moodle-local_shopping_cart

Other
4 stars 6 forks source link

Testing: GitHub Mustache lint issues #39

Closed semteacher closed 11 months ago

semteacher commented 1 year ago

Branch: "USI" The following parts of templates violates HTML standards as per GitHub Mustache lint report:

/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/history_item.mustache - WARNING: HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li class="list-group-item flex-column align-items-start text-dark">    <)
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/shopping_cart_item.mustache - WARNING: HTML Validation error, line 12: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (d><body><li id="item-mod_booking-main-3"    class="clearfix"    data-price='133'    data-name='Tenniscourse'    data-component='mod_booking'    data-area='main'    data-itemid='3'    data-item="shopping_cart_item"    data-currency=''    data-userid=''>    <)
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/cashier.mustache - WARNING: HTML Validation error, line 44: No “p” element in scope but a “p” end tag seen. (          </p>     )
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/cashier.mustache - WARNING: HTML Validation error, line 52: Element “div” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.) (          <div class="text-center">[[ car)
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/cashier.mustache - WARNING: HTML Validation error, line 116: Element “div” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.) (          <div class="text-center">[[ car)
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/cashier.mustache - WARNING: HTML Validation error, line 136: No “p” element in scope but a “p” end tag seen. (          </p>     )
/home/runner/work/moodle-local_shopping_cart/moodle-local_shopping_cart/moodle/local/shopping_cart/templates/cashier.mustache - WARNING: HTML Validation error, line 156: Element “div” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.) (          <div class="text-center">[[ car)

image

PS: possible solutions - or eliminates tags like<div> from inside <ul> and<li> OR <ul> and <li> have to be replaced with yet another div's, styled as lists by CSS