strange strings in lang file

Wunderbyte-GmbH / moodle-local_wunderbyte_table

Wunderbyte Table

Other

4 stars 5 forks source link

strange strings in lang file #38

Closed danmarsden closed 8 months ago

danmarsden commented 9 months ago

https://github.com/Wunderbyte-GmbH/moodle-local_wunderbyte_table/blob/main/lang/en/local_wunderbyte_table.php#L78-L81

https://github.com/Wunderbyte-GmbH/moodle-local_wunderbyte_table/blob/main/lang/en/local_wunderbyte_table.php#L99C10-L106

How would a translator know how to translate these things correctly? - they appear to be config/demo content that may not be usefully translated?

danmarsden commented 8 months ago

I still see the weird strings in there... I also see that the strings are exactly the same in both the EN and DE lang files which suggests to me that they shouldn't be in the lang file at all as no translation is being done? - can they be hard-coded in the code instead of putting a lang string in the lang pack that can't be translated, confusing the language translators on AMOS?

georgmaisser commented 8 months ago

Hi, we opted to add the German translations. Even though the demo site is basically addressed to developers, who need to speak some amount of English, some people still might want to include also the demo strings in their translations. Therefore, we decided against hardcoding.