Wunderbyte-GmbH / moodle-local_wunderbyte_table

Wunderbyte Table
Other
4 stars 5 forks source link

Fatal error: Cannot override final method #48

Closed jwalits closed 6 months ago

jwalits commented 6 months ago

We are currently seeing the following error with the mod/booking plugin and the issue arises from local_wunderbyte_table\wunderbyte_table class defining the __construct method as final

2024-02-21_12-46

georgmaisser commented 6 months ago

Hi, thank you for your contribution!

The last version of booking is compatible with the new "final" constructor. The reason we added it was that because of the caching of the wb table class, there is a risk of passing on the wrong class instance to the wrong user. Passing on values in the constructor and storing them in the class increases the risk of unwanted effects.

But I see that we need to stay backwards compatible for a while.