Wunderbyte-GmbH / moodle-mod_booking

Moodle Booking Module
https://www.wunderbyte.at
21 stars 38 forks source link

Poll URL fields in booking_options are very small #515

Closed danbuntu closed 1 month ago

danbuntu commented 1 month ago

Describe the bug The pollurl and pollurlteachers are set to varchar(255). This is a very small number. We regularly see users with teams.microsoft.com urls that are push 500 chars or safelink.protection urls that can push 800 chars

Versions uses Moodle version: 4.1 Boooking version: current

To Reproduce Steps to reproduce the behavior: Create a booking with a pollurl over 255 chars long such as one from MS teams

Expected behavior I think it might be worth setting the poll urls to varchar(1000)

eynimeni commented 1 month ago

Hi @danbuntu we propose that you shorten the URLs before the insert. but to make it even more convenient, we upgraded the db fields in the new version 8.3.6 Enjoy 😊