Test Track Changes Feature

[eynimeni]

I have made a screenrecording explaining the new feature changes that tracks changes in updated bookingoptions. there is a new placeholder {changes} in the rules that will replace the mailtemplates in the future. could you please a) have a look at the failing actions ins the branch: track_changes_in_boform and b) write tests about this new feature

here are the recordings. Let me know if anything is unclear. https://we.tl/t-Mk88AUK8LF

Behat tests:

• [x] review option editing changes using in-place table
• [x] use rule to email list of changes (via live logs it is only possible to verify the subject but not the body of message)
• [x] on/off deprecated email settings

=========================== phpunit tests

• [x] review option editing changes using event data

[semteacher]

Bug: I have changed teacher for option but it does not registerd under "recent changes". Instead this has been added

[semteacher]

@eynimeni about "Still use legacy mail templates ( booking | uselegacymailtemplates )" feature It works now significantly differnt than in your video (2nd recording). With negation of settings there

I can see "deprecated templates" only plugin setting unchecked

Moreover I see category and editboxes for messages under booking settings - not under option settings

This part under option settings always the same

Please, verify how and where this has to work

[semteacher]

• [x] fixed There is a php 7.4 compatibility issue:

Despite all my attempts to fix (commit not in "origin" repo)

Still got the same error

[eynimeni]

@eynimeni about "Still use legacy mail templates ( booking | uselegacymailtemplates )" feature It works now significantly differnt than in your video (2nd recording). With negation of settings there

I can see "deprecated templates" only plugin setting unchecked

Moreover I see category and editboxes for messages under booking settings - not under option settings

This part under option settings always the same

Please, verify how and where this has to work

Yes! Sorry for that. I misunderstood what was deprecated and made the screenrecording with the old version and forgot to give you the update. Correct behaviour is implemented now. Find deprecated forms in:

• Pluginsettings
• Booking Instance settings (new with 9e1877b67020fd561a8a90ff2a5ebd1bc84b7610)
  • only visible when setting in plugin defined
  • pro version is not required anymore
  • information about deprecate status
  • link to booking rules

In the settings of a bookinoption NO deprecation warning and display always.

[semteacher]

@eynimeni By writing phpunit tests I found number of occurences like this in the list of recorded changes

I think that change of kind of empty value should not being registered as change. OR @georgmaisser - should we standartize defaults between bookig_option::create() and bookig_option::update() ?

[semteacher]

A potential issue with dates processing for changes exist. At github option dates not being assigned at option creation all the time.

• local run of test_option_changes() test

• run of test_option_changes() at github

UPD: additional test run at github with var_dump

[eynimeni]

remaining problem see #545

[semteacher]

During debugging of phpunit faced the following error when tried to use {changes} placeholder in the email template: 1) mod_booking\rules_test::test_rule_on_teacher_added Error: Object of class stdClass could not be converted to string

/var/www/html/lib/mustache/src/Mustache/Template.php:66 /var/www/html/lib/outputrenderers.php:208 /var/www/html/mod/booking/classes/output/renderer.php:491 /var/www/html/mod/booking/classes/event/bookingoption_updated.php:83 /var/www/html/mod/booking/classes/placeholders/placeholders/changes.php:84 /var/www/html/mod/booking/classes/placeholders/placeholders_info.php:115 /var/www/html/mod/booking/classes/message_controller.php:327 /var/www/html/mod/booking/classes/message_controller.php:272 /var/www/html/mod/booking/classes/task/send_mail_by_rule_adhoc.php:107 /var/www/html/lib/phpunit/classes/advanced_testcase.php:722 /var/www/html/mod/booking/tests/booking_rules/rules_test.php:147 /var/www/html/lib/phpunit/classes/advanced_testcase.php:81 Error has been raised just at renderring

debugger tried to create a file

During manual tests no error occurs...

[semteacher]

above fixed there https://github.com/Wunderbyte-GmbH/moodle-mod_booking/commit/422ed09332d7f4eaa4602e17d8542ca598103f4d https://github.com/Wunderbyte-GmbH/moodle-mod_booking/commit/1f1c57a4b51f12bc98916b2c0f9083c29abb064b