Testing connection bookingoption - moodle course

[eynimeni]

We introduced / improved a (pro) feature, the "Automatic creation of Moodle courses" from bookingoptions. In a bookingoption there is a section "Moodle Courses" where it can be chosen if users of a bookingoption should be enroled into a moodle course. It can also be a moodle course newly created. If a course is to be created, the setting config newcoursecategorycfield gives the name of the custom option field of the booking option (in section "other fields"). If there is a value found here, course will be created in a category of this name. If the name doesn't exists yet, the new category is created. If a template is selected in the config section, all courses with these tags can be used as templates for the course creation.

Could you please write tests for scenarios like: behat tests

• [x] in configsettings no category selected, bookingoption "create new empty Moodle course", checkbox unchecked -> new empty course created in first category with users of bookingoption enroled
  • [x] in configsettings no category selected, bookingoption "create new empty Moodle course", checkbox checked -> new empty course created in first category, users of bookingoption enroled after coursestart
  • [x] in configsettings customoptionfield name selected, bookingoption "create new empty Moodle course", in bookingoption other fields for customoptionfield name value given entered for existing category -> new empty course created in category of mentioned name
  • [x] in configsettings customoptionfield name selected, bookingoption "create new empty Moodle course", in bookingoption other fields for customoptionfield name value given entered NOT for existing category -> new empty course created in newly created category of mentioned name
  • [x] use course template ... and so on

phpunit tests

• [x] in configsettings no category selected, bookingoption "create new empty Moodle course", checkbox unchecked -> new empty course created in first category with users of bookingoption enroled

• [x] in configsettings no category selected, bookingoption "create new empty Moodle course", checkbox checked -> new empty course created in first category, users of bookingoption enroled after coursestart

• [ ] in configsettings customoptionfield name selected, bookingoption "create new empty Moodle course", in bookingoption other fields for customoptionfield name value given entered for existing category -> new empty course created in category of mentioned name

• [ ] in configsettings customoptionfield name selected, bookingoption "create new empty Moodle course", in bookingoption other fields for customoptionfield name value given entered NOT for existing category -> new empty course created in newly created category of mentioned name

• [ ] use course template

[eynimeni]

screenrecording here: https://we.tl/t-5xcbHGiJoE

[semteacher]

1. @eynimeni Thank you for screen recording.
2. I have already started with simplest case but faced an issue
   • for the simple "connected course"
   • when student has booked it
   • it not become enrolled. Button "goto Moodle course" leads to

Does this feature supposed to be still working?

[eynimeni]

I didn't cover it in my recording. did you enable Auto-enrol in you settings?

Does the error persist with this setting?

[semteacher]

For case of simple commection of existing course (https://github.com/Wunderbyte-GmbH/moodle-mod_booking/commit/ccf8fdb8ad23bbddc2162c5fc9ae1e953a3de5b9):

• automatic test passed OK
• manual test still fails (all settings as above, booking option in course 1, connected course 2, student has been enrolled in course 1, book option, got confirmation but "go to course" show "You cannot enrol yourself in this course" page), have tried with 2 students... (could it be issue with dev env?)