search

Wunderbyte-GmbH / moodle-mod_booking

Moodle Booking Module
https://www.wunderbyte.at
21 stars 39 forks source link

Booking cannot be cancelled #579

Closed AntonT76 closed 2 months ago

AntonT76 commented 2 months ago

Dear Wunderbyte-Team,

I am currently testing the booking plugin 8.2.4 (2024041100) on Moodle 4.1.11+ and have encountered the following problem: It is not possible for a user to cancel a booking

As a teacher I set booking to "Cancelling is only possible until certain date: DD-MM-YYYY", but for a user there is no button for cancelling.

Browser: Edge 1.26 64bit OS: Windows 10 22H2 (build 19045.4529) Moodle 4.1.11+ LTS (Theme: Boost Union v4.1-r28)

br, Anton

dasistwas commented 2 months ago

Could you verify if the problem persists in the latest version: https://github.com/Wunderbyte-GmbH/moodle-mod_booking/tags

AntonT76 commented 2 months ago

Hi @dasistwas ,

actually I could not do an update on this Moodle Version 4.1.11+, because we do not have direct access to it. But we have an other developer Moodle (also 4.1.11+, Booking 8.2.4) and there was an other issue:

With the "old" Booking (8.2.4) and also your beta booking version (8.4.7) I'm not able to config a new booking option. I got the error message:

_Fehler: Undefined constant "mod_booking\option\fields\MOD_BOOKING_OPTION_FIELDSHORTURL"

We have provided our developer Moodle with sub-URLs (eg: https://mymoodle.com/devmo1, https://mymoodle.com/devmo2, https://mymoodle.com/devmo3, ... Maybe it has something to do with that?

br, Anton

dasistwas commented 2 months ago

What PHP version are you using?

dasistwas commented 2 months ago

Concerning users can't cancel: You have to allow that in booking instance settings. We are running automated tests against that feature so it should work. See screenshot: Activate the last option in advanced settings: Screenshot 2024-07-18 at 10-15-01 Editing Booking Wunderbyte

AntonT76 commented 2 months ago

What PHP version are you using?

we are using PHP Version 8.1.29

AntonT76 commented 2 months ago

Concerning users can't cancel: You have to allow that in booking instance settings. We are running automated tests against that feature so it should work. See screenshot: Activate the last option in advanced settings: Screenshot 2024-07-18 at 10-15-01 Editing Booking Wunderbyte

ok, thank you and sorry for the confusion. I didn't see this feature - now canceling is possible. br, Anton

dasistwas commented 2 months ago

_Fehler: Undefined constant "mod_booking\option\fields\MOD_BOOKING_OPTION_FIELDSHORTURL"

Hi, we think there is a problem with your $CFG->dirroot. We can't reproduce the problem and all automated tests, that are actually doing configurtation of booking options constantly are passing.

AntonT76 commented 2 months ago

Hi, thank you, I will check the dirroot options. br Anton