Completion Condition not triggered

Wunderbyte-GmbH / moodle-mod_booking

Moodle Booking Module

https://www.wunderbyte.at

21 stars 40 forks source link

Completion Condition not triggered #629

Open JoshuaAuthement opened 1 month ago

JoshuaAuthement commented 1 month ago

Describe the bug When the completion condition is set to 'Add requirements' then choosing 'Count of entries', we set it to 1. The condition is not marked as completed when a user books a session.

Versions uses Moodle version: 4.3 Booking version: 8.2.4

To Reproduce Steps to reproduce the behavior:

Go to the booking activity settings.
Click on completion conditions. Select 'Add requirements' then check the box for 'Count of entries' and enter 1 into the text box. Save changes.
Have a user enroll in a booking session.
The activity is not marked as complete.

Expected behavior Once a user books a session, the activity should be marked as complete.

Screenshots

Booking Settings:

User booked:

Activity for user not marked complete:

dasistwas commented 1 month ago

Could you try if the issue still persists in the latest release: https://github.com/Wunderbyte-GmbH/moodle-mod_booking/releases/tag/v8.6.19

dasistwas commented 1 month ago

Any news about this @JoshuaAuthement ?

dasistwas commented 1 month ago

It is possible that this feature does not work right now.

dasistwas commented 1 month ago

@semteacher could you have a look at that?

JoshuaAuthement commented 1 month ago

Any news about this @JoshuaAuthement ?

We are working on installing the plugin from GitHub.

semteacher commented 1 month ago

As I can see from code and recent tests, completion feature now working in the following way:

Even with all settings as above, student's completion has to be confirmed by teacher / booking manager.
For this in booking instance for the option student has booked, the followng settings has to be done:
This lead to the "complete" state in the "activity completion" report
Which, in turn, will indicates for student that activity has been completed:

JoshuaAuthement commented 1 month ago

We created a blank dev site to test the plugin. I was going to say that the completion condition was not triggered, but I see from the post above that it has to be manually confirmed. Something else that was noticed related to the completion condition is that it is not listed on the course home page.

Also, when you go to the settings and click save, the completion condition is triggered without manually confirming it. However, when another user books a session, the condition is still not triggered.

semteacher commented 1 month ago

@georgmaisser I have fixed above bug (https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/629#issuecomment-2389348958): Once teacher (manager / admin) marks designated number of booked options as completed - status has been updated properly Fix under 401_testing branch. The only remaining issues - stings in German has to be updated according to English UPD: I think #474 has to be addressed too in order to fix all related things. Can do it but will takes some time