Wunderbyte-GmbH / moodle-mod_booking

Moodle Booking Module
https://www.wunderbyte.at
21 stars 40 forks source link

Waiting List Process #693

Closed danbuntu closed 1 week ago

danbuntu commented 1 week ago

Hello

Could you please explain the workflow for users on a waiting list?

We have booking that is full and has users on the waiting list.

When we cancel ones of the users on the booking the users on the waiting list receive an email with a status change of 'You are on the waiting list'. They aren't automatically moved on on the now free space. Additionally if an other user then goes to the booking they they are able to booking onto it and so jump the queue.

dasistwas commented 1 week ago

@bernhard-wunderbyte could you have a look at that? @danbuntu could you provide as the version used.

danbuntu commented 1 week ago

@dasistwas sure we're using 8.4.7

bernhard-wunderbyte commented 1 week ago

@danbuntu Please have a look at you global booking settings under https:///admin/settings.php?section=modsettingbooking

There you'll find a setting called "Turn off automatic moving up from waiting list after a booking option has started." Please make sure that this checkbox is not checked. Please let me know if this solved the issue or if we have to further investigate this.

Bildschirmfoto 2024-11-08 um 09 44 56
danbuntu commented 1 week ago

These are all set to off:

[image: image.png]

On Fri, 8 Nov 2024 at 08:46, Bernhard Fischer-Sengseis < @.***> wrote:

@danbuntu https://github.com/danbuntu Please have a look at you global booking settings under https:// /admin/settings.php?section=modsettingbooking

There you'll find a setting called "Turn off automatic moving up from waiting list after a booking option has started." Please make sure that this checkbox is not checked. Please let me know if this solved the issue or if we have to further investigate this. Bildschirmfoto.2024-11-08.um.09.44.56.png (view on web) https://github.com/user-attachments/assets/456249e7-7137-4034-a408-85e7459ba740

— Reply to this email directly, view it on GitHub https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/693#issuecomment-2464145464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFID4XHWGGGH3QAXJE23NDZ7R273AVCNFSM6AAAAABRLKKXLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUGE2DKNBWGQ . You are receiving this because you were mentioned.Message ID: @.***>

bernhard-wunderbyte commented 1 week ago

Can you please also check if the booking option has a price set? Currently, the automatic moving up from the waiting list to booked users is not working if a price is set. So within the booking option you have to make sure that the checkbox "Only book with price" is turned off.

danbuntu commented 1 week ago

Yes we have that option turned off:

[image: image.png]

On Fri, 8 Nov 2024 at 09:34, Bernhard Fischer-Sengseis < @.***> wrote:

Can you please also check if the booking option has a price set? Currently, the automatic moving up from the waiting list to booked users is not working if a price is set. So within the booking option you have to make sure that the checkbox "Only book with price" is turned off.

— Reply to this email directly, view it on GitHub https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/693#issuecomment-2464235103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFID4S6SYBYTRGV5OWPVBLZ7SAQPAVCNFSM6AAAAABRLKKXLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUGIZTKMJQGM . You are receiving this because you were mentioned.Message ID: @.***>

bernhard-wunderbyte commented 1 week ago

Do you have shopping cart installed (local_shopping_cart)?

danbuntu commented 1 week ago

Yes, I have it installed.

On Fri, 8 Nov 2024 at 12:49, Bernhard Fischer-Sengseis < @.***> wrote:

Do you have shopping cart installed (local_shopping_cart)?

— Reply to this email directly, view it on GitHub https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/693#issuecomment-2464678891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFID4W2PUYPK76KFDDLMHDZ7SXOHAVCNFSM6AAAAABRLKKXLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUGY3TQOBZGE . You are receiving this because you were mentioned.Message ID: @.***>

bernhard-wunderbyte commented 1 week ago

If you do not need it, you can uninstall it and see if it works then. @georgmaisser Can you have a look at this?

georgmaisser commented 1 week ago

I just had a look again, and there are exactly three reasons why the syncing of the waitinglist is turned off

When you use prices and the shopping cart, you should notify users on the waitinglist that they can pay. This can be done via the Booking Rules.

Please be aware that when you answer via e-mail, we don't see any pictures you send, so please come on GitHub to send us full information. Thank you!

bernhard-wunderbyte commented 1 week ago

I'll close this for now.