Wunderbyte-GmbH / moodle-mod_booking

Moodle Booking Module

https://www.wunderbyte.at

21 stars 41 forks source link

Bugfix: Block campaigns with price MUSI-621 #719

Open eynimeni opened 6 days ago

eynimeni commented 6 days ago

[ ] make sure campaigns containing price are blocked as well by active and applicable campaign

Regarding tests @semteacher We need to adjust tests to make sure, that options aren't bookable when there is a price set. This is not working yet. I will fix it ASAP. @semteacher you could already start extending the tests (in a separate branch) - as a form of test driven development. I will be able to work on this from tuesday on (soonest)

689

semteacher commented 6 days ago

@eynimeni Could you, please, provide me with some sort of scenario (settings, expected outcome)

eynimeni commented 6 days ago

the scenarios as described in https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/689 and the bookingoptions have a price set (or multiple prices for price-categories) it shouldn't be possible to book a bookingoption with price if a campaign is blocking it (at the moment, it is possible)

semteacher commented 5 days ago

For the following:

students
prices / options / answers
and for campaing like in the https://github.com/Wunderbyte-GmbH/moodle-mod_booking/issues/689#issuecomment-2472906312 I got the following: a) student 1 (seems correct for me?) b) students 2 and 3 (seems correct for me?) Same case with 2nd blocking campaign. It seems to me that blocking has been extended for option with prices already?

eynimeni commented 1 day ago

great, thank you! I thought there was a problem because I tested with capability 'bookforothers' this enables booking (as for other conditions) maybe you could extend the test for one more person with this capability and make sure, he/she is able to book although campaign is displayed