Wunderbyte-GmbH / moodle-mod_mooduell

Player vs. Player Game using Moodle Quiz Questions (Multiplayer Oriented Online DUELL)
Other
2 stars 4 forks source link

Second level namespace violate the naming rules #75

Open purnendudash opened 6 months ago

purnendudash commented 6 months ago

Please refer to https://moodledev.io/general/development/policies/codingstyle#rules-for-level2

Your custom namespaces like fonts, help, model, pdf, report or privacy violate this naming rule. There are good reasons why it should be followed, mainly to avoid potential conflicts in the future. All these should be under classes/local/ namespace.

https://github.com/Wunderbyte-GmbH/moodle-mod_mooduell/blob/9911500e88b15585d0c52a8113c12e3f2100a95b/classes/task/challenge_results_task.php#L16

georgmaisser commented 6 months ago

Hi, thank you for your very helpful feedback. But are you sure about this instance? I would see task as core api, like event, and there, in your referenced document, we find this example:

Bildschirmfoto 2024-03-12 um 11 52 06

Do we missunderstand sth? Thank you!