search

Wunderbyte-GmbH / moodle-theme_campus

Moodle theme for onlinecampus
4 stars 4 forks source link

Validator: ul within ul not permitted #20

Closed dasistwas closed 3 years ago

dasistwas commented 3 years ago

There is a ul within ul, which throws an error on html validation:

https://github.com/Wunderbyte-GmbH/moodle-theme_campus/blob/dd3f42796fcf53866fe5f9e826e49217d75ba7ed/layout/tiles/navbar.php#L43

gjb2048 commented 3 years ago

@dasistwas Odd as you can have nested lists: https://www.w3schools.com/tags/tag_ul.asp - but perhaps because of ul > ul and not ul > li > ul

dasistwas commented 3 years ago

Like this

 <ul>
  <li>Coffee</li>
  <li>Tea
    <ul>
      <li>Black tea</li>
      <li>Green tea</li>
    </ul>
  </li>
  <li>Milk</li>
</ul>
gjb2048 commented 3 years ago

Yes

gjb2048 commented 3 years ago

@dasistwas Looked at it, tried something out, seems fine, actually nesting not needed! Elements already 'pulled right' - master_dev for M3.9 updated.

dasistwas commented 3 years ago

thank you for fixing this.