search

Wunderbyte-GmbH / moodle-theme_squared

Moodle Theme based on squares
GNU General Public License v3.0
2 stars 3 forks source link

Replace google+ link and icon with instagram in general settings of the theme #5

Closed dasistwas closed 5 years ago

dasistwas commented 5 years ago

We need to replace our google+ account with instagram account. Therefore we would need to replace google+ link with instagram link in the general theme settings. Also icon should be replaced. And there is a little bug: A line is drawn through all the icons. This line should be removed.

gjb2048 commented 5 years ago

Hi David,

Will do.

Gareth

gjb2048 commented 5 years ago

Note: In footer settings.

gjb2048 commented 5 years ago

Must be 29px by 29px -> https://en.instagram-brand.com/assets/icons

gjb2048 commented 5 years ago

Hi David,

Done. I've had to alter the size and padding because of Instagram's mandatory guidelines.

Gareth

dasistwas commented 5 years ago

Hi Gareth,

great work thank you! Looks really good. One thing left to do: When the link is left empty in the settings, could you also remove the specific icon from the footer?

Kind regards, David

gjb2048 commented 5 years ago

Hi David,

That's odd, but will do.

G

gjb2048 commented 5 years ago

Hi David,

Done. There was old code that I've removed and old new code that I've fixed.

Kind regards,

Gareth

dasistwas commented 5 years ago

Thank you! Great work as usual.