Open dasistwas opened 2 years ago
@dasistwas What do you want me to do about the 'navbarsearch' setting (https://github.com/Wunderbyte-GmbH/moodle-theme_squared/issues/8#issuecomment-835421049)? As I suspect it is related to "The search field in the navbar is not working (width 0 and button not responding".
@dasistwas Just checked and I can replicate the error, so will be down to the change for 'core/search-input', therefore please could you let me know how you'd like this rectified please -> https://github.com/Wunderbyte-GmbH/moodle-theme_squared/issues/8#issuecomment-835421049.
Hi @dasistwas,
This is the patch in Adaptable -> https://gitlab.com/jezhops/moodle-theme_adaptable/-/commit/6fd3466befa33f0aa0d7834964eee255b62655d0 and the specific code that I can adapt -> https://gitlab.com/jezhops/moodle-theme_adaptable/-/blob/6fd3466befa33f0aa0d7834964eee255b62655d0/classes/output/core_renderer_toolbox.php#L3543-3571. I just need to know what you'd like me to do please.
Kind regards,
Gareth
HI Gareth, if you could apply that solution in squared, that would be great. Kind regards, David
Hi David (@dasistwas),
All implemented and managed to keep all three existing options for 'navbarsearch'. Please let me know if you're happy with the result:
and I'll publish on Moodle dot org.
As there is a change to the function definition of PHPUnit's setUp() and because the search has changed here, I've created a MOODLE_39_STABLE branch and now 'master' is M3.10 with the square name 'Rathausplatz'.
Kind regards,
Gareth
@dasistwas Any news on this please?
Looks good, but too many search boxes on this page:
https://onlinecampus.virtuelle-ph.at/course/search.php?context=2&q=test
@dasistwas Ok, I'll remove the ones on the navbar and breadcrumb.
Also, realised that I can ignore 'SetUp' and use own method instead in the future.
@dasistwas I've removed the search boxes as much as I can on the above commit, however the one on the navbar on the course search page cannot be removed, due to non-overrideable core code in '/course/search.php':
if ((can_edit_in_category() || !empty($usercatlist))) {
$aurl = new moodle_url('/course/management.php', $searchcriteria);
$searchform = $OUTPUT->single_button($aurl, get_string('managecourses'), 'get');
} else {
$searchform = $courserenderer->course_search_form($search);
}
$PAGE->set_button($searchform);
@dasistwas I'll publish the theme on Moodle dot org as soon as I can.
@dasistwas Released: https://moodle.org/mod/forum/discuss.php?d=428636 - I'll eMail you with specifics!
Hi @gjb2048 ,
thank you for the M3.10 version of squared. Here are some issues, which we would be happy if you could fix them;