Wunkolo / UWPDumper

DLL and Injector for dumping UWP applications at run-time to bypass encrypted file system protection.
MIT License
811 stars 110 forks source link

Do not pause when tool can run autonomously (i.e. when arguments are supplied) #53

Closed Measurity closed 3 years ago

Measurity commented 3 years ago

Would be nice so it does not require user input to unpause when using this tool as part of an automated procedure. In addition it does not need to open the DUMP folder when done.

Code that causes "issue" https://github.com/Wunkolo/UWPDumper/blob/c29e9d654d8743049ecc082ba8a414731f727a6e/UWPInjector/source/main.cpp#L413

This code always opens DUMP folder when done but when it's part of automated procedure this can be confusing (and it doesn't open a custom dump directory if specified with -d). https://github.com/Wunkolo/UWPDumper/blob/c29e9d654d8743049ecc082ba8a414731f727a6e/UWPDumper/main.cpp#L66-L69

Example of how I use it https://github.com/Measurity/AddModSupportMSStoreSubnautica/blob/8bf149f0d32862f9507a47118fa4dadbab8fcd0a/AddModSupportMSStoreSubnautica/Program.cs#L47

Wunkolo commented 3 years ago

How's a command like option like -c(for continuous) to disable pausing and folder-opening?

I'd like the default behavior to be that it pauses and opens the dump-folder since most end-users will be running it and would like to be able to scroll up and down the log once dumping is done rather than have it close automatically(both to verify the files dumped or for valuable diagnostic data should something go wrong).

Measurity commented 3 years ago

Makes sense to add an argument for it instead of silently doing something unexpectedly. I think a -s for --silent is more conventional (but it can also imply that it won't log or show anything at all so either way is fine).

Wunkolo commented 3 years ago

Added it as a -c flag. I also did some other small refactors such as making the injector itself open up the target path rather than the injected process so that it can be conditionally executed in the case of continuous execution. Lemme know how it goes. Also added some more robust controls over the custom folder path, so it supports paths relative current-working-directory(such as UWPInjector.exe -p 15936 -d ./blah) and it will automatically convert it into an absolute path internally.

Measurity commented 3 years ago

Thank you for the quick implementation. I just tested it and works just how I needed it 👍