Add new setting to AimAssist `onlyAllowWhileClicking`

[TejasLamba2006]

Description

Added a new feature to the codebase: onlyAllowWhileClicking CheckboxSetting. When enabled, this setting prevents the aim from targeting entities when the attack key is not pressed.

Testing

I have tested these changes by enabling the onlyAllowWhileClicking setting and verifying that the aim does not target entities when the attack key is not pressed. Additionally, I have checked that the aim behaves as expected when the setting is disabled. I recommend the reviewer to perform similar tests to validate the functionality.

References

No related issues or forum posts at the moment.

[coderabbitai[bot]]

Walkthrough

## Walkthrough The `AimAssistHack` class has been updated to include a new feature that allows users to control the aiming behavior with a checkbox setting named `onlyAllowWhileClicking`. This setting ensures that aiming assistance is provided only when the user is actively clicking. Both the `onUpdate` and `onRender` methods have been modified to respect this new setting, enhancing the flexibility and user control over the aim assist functionality. ## Changes | File Path | Change Summary | |------------------------------|----------------------------------------------------------------------------------------------------| | `.../hacks/AimAssistHack.java` | - Added `onlyAllowWhileClicking` checkbox setting.
- Modified `onUpdate` and `onRender` methods to consider the new setting. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

---

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

[github-actions[bot]]

This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks.

Pull requests should be closed if:

• They have been superseded by another pull request
• They are out of scope or don't align with the project
• They have become obsolete due to other changes
• They have bugs or conflicts that won't be resolved

[Alexander01998]

Hey @TejasLamba2006,

Thanks for the pull request! I took a look at the changes, and I appreciate the effort you've put into this. However, I'm a bit hesitant about merging this PR since I'm not sure that this setting would be very practical.

Typically, you'd want AimAssist to aim before you click, to ensure that your attack doesn't miss. If it only starts aiming when you're already clicking, it seems like that would cause most of your attacks to miss and waste attack cooldown progress.

I could be wrong though. Feel free to let me know if there's a use case for this setting that I'm not considering.

[TejasLamba2006]

Hi @Alexander01998,

Thank you for taking the time to review my pull request and for your thoughtful feedback. I understand your concerns about the practicality of this setting. However, I believe that this feature could indeed be beneficial for several reasons.

Firstly, many other Minecraft hacking clients already offer this option. By including it in our client, we can ensure that we are providing a feature set that is on par with, if not superior to, what our competitors offer. This could help attract users who are looking for this specific functionality.

Secondly, having AimAssist activate only when clicking could potentially make the client less detectable by anti-cheat systems. If the AimAssist is constantly rotating when a player is nearby, even without any user input, it could raise suspicions and increase the likelihood of detection. By contrast, activating AimAssist only when the user is clicking could make the behavior seem more natural and less like a hacking client, thereby reducing the risk of detection.

I hope this clarifies the potential benefits of this feature. I'm open to further discussion and would be happy to make any necessary adjustments to address your concerns.