search

WurthElektronik / WirelessConnectivity-SDK_STM32

Software development kit for Würth Elektronik eiSos wireless connectivity products (implementation for STM32 microcontrollers).
Other
9 stars 7 forks source link

Redundant code in Fillchecksum #3

Closed timnMK closed 8 months ago

timnMK commented 1 year ago

if ((cmd->Length >= 0) && (cmd->Stx == CMD_STX))

My PIC compiler moans that the first expression always produces a true result, quite right too. I've removed it and just left the Stx expression, all seems to work OK unless there is some hidden feature here?

wm-eisos commented 8 months ago

Hey,

Yes that is correct. A new major release of the drivers has been released v2.0.0 (7faf9c8aaaa09c94a8b786f1ca0002861eedea74)

Best Regards Wajdi