Wutname1 / SpartanUI

SpartanUI
http://spartanui.net
Mozilla Public License 2.0
29 stars 11 forks source link

Classic - Hunter - Pet Happiness #233

Closed MidnightJay closed 4 years ago

MidnightJay commented 5 years ago

I've searched in the options along with bartender and cannot seem to find a spot to turn on the option for pet happiness for hunters to determine when the pet needs to be fed.

Can you advise where this option is located so I can use this amazing UI for my hunter.

Thanks!

Wutname1 commented 5 years ago

What skin are you using it should be on your pets frame

MidnightJay commented 5 years ago

I've tried a few (War one currently) and it doesn't show it anywhere on the pet frame that I can find, I disable the UI and it shows just fine.

Do you have a screenshot of where it should be located and maybe that will help me?

Thanks!

Wutname1 commented 5 years ago

It should be on the left side of all the frames (War pictured) image

Addition ref: https://github.com/Wutname1/SpartanUI/commit/ae34c8b0613a87bf291b59e416172b1bb4edd970

Wutname1 commented 5 years ago

Do you have your pet out when you load the game? Summon your pet and /reload see if it appears i wonder if there is a bug relating to it updating.

MidnightJay commented 5 years ago

I don't have the happiness icon at all. Yes it's out when loading the game, then I stable, reload ui and still have nothing. The icon is missing all together.

I even tried stabling the pet, logging out, logging back in and getting the pet out of the stable and no change

image

Wutname1 commented 5 years ago

If one of you are up to helping me test (No hunter atm) I need a hunter to update a file: https://raw.githubusercontent.com/Wutname1/oUF_PetHappiness/master/oUF_PetHappiness.lua That file needs to replace your current one at: World of Warcraft\_classic_\Interface\AddOns\SpartanUI\libs\oUF_PetHappiness

MidnightJay commented 5 years ago

updated the file and no change unfortunately .... happiness icon still doesn't show up

MidnightJay commented 5 years ago

Let me know if you want me to try testing anything else.

Note I've disabled everything expect for SUI and Bartender and the issue occurs. If you need to redo a complete package with a test name I can install and test it too if you need to.

thanks for taking the time to fix this, SUI is by far my favorite ... possibly ever.

AlwaysOnTheHunt commented 5 years ago

Hello.

I have the same issue on my hunter. :( The happiness icon on the pet frame won't show at all. Tried to look at the settings, but no results. I tried to replace the updated file, as MidnightJay where instructed to, and it didn't work sadly. :( Really like SpartanUI, so i hope it will be fixed. Let me know if you need some more hands for testing, would love to help resolve the issue. Regards! :)

Wutname1 commented 5 years ago

So I leveled a hunter to 10 today and I am unable to replicate.

The happiness icon appears on the left of the pet frame on all the skins for me. https://imgur.com/a/BaV2JbK

Try putting this in your chat for me: /script print(SUI_petFrame.PetHappiness) You should get a output in your chat of table: <guid> Example: image

StingMcRay commented 5 years ago

When i run the script i get this output : afbeelding

MidnightJay commented 5 years ago

I get: table: 00000235A2A78F10

Wutname1 commented 5 years ago

You will always get a different table ID (it is random.) Does /script SUI_petFrame.PetHappiness:Show() make it appear?

MidnightJay commented 5 years ago

Oh sorry missed that, I was checking while at work lol

So I did that part and no change sadly

image

MidnightJay commented 5 years ago

So I was hoping it was due to the updated oUF_PatHappiness.lua file you gave me so I installed the original one again that came with the download and still no change.

I'm at a loss

Wutname1 commented 5 years ago

Try these 3 commands me know what happens:

/script print(SUI_petFrame.PetHappiness:IsVisible()) /script SUI_petFrame.PetHappiness:Show() /script print(SUI_petFrame.PetHappiness:IsVisible())

We are looking to see if the state is changing between true & false after running the Show() command.

MidnightJay commented 5 years ago

Just ran the 3 above scripts and the both values return as 'true' image

Wutname1 commented 5 years ago

😢 ok lets try manually clearing where it is and setting it to be below the pet frame. /script SUI_petFrame.PetHappiness:ClearAllPoints() /script SUI_petFrame.PetHappiness:SetPoint('TOP', SUI_petFrame, 'BOTTOM', 0, -10)

MidnightJay commented 5 years ago

Tried that and no change. Value is still showing true

Dhubhghall commented 5 years ago

Hi, as of today and the new release i have the same problem. Pet happiness wont show and i tried everything above. I reverted back to the old release and pet happiness is still gone....

Road-block commented 5 years ago

Does it show if you move it outside of the petframe? It might be a strata issue.

Wutname1 commented 5 years ago

@Road-block that was the idea behind the above script commands i posted.

Would anyone having this issue be willing to give the latest 6.0 Alpha a try for me? https://www.curseforge.com/wow/addons/spartan-ui/files/2813567

Thorsteenster commented 4 years ago

Any updates on this? I just installed on Classic for my Hunter and pet happiness isn't showing after following above steps. Resolution or move onto another UI AddOn? (First time UI AddOn user...)

MidnightJay commented 4 years ago

Hey,

It's been working fine since your last update. Good job!

On Tue, Mar 24, 2020 at 5:17 PM Thorsteenster notifications@github.com wrote:

Any updates on this? I just installed on Classic for my Hunter and pet happiness isn't showing after following above steps. Resolution or move onto another UI AddOn? (First time UI AddOn user...)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Wutname1/SpartanUI/issues/233#issuecomment-603553535, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDGVRWHVDIEFB7ZPOZDZN3RJE5PPANCNFSM4IT6H5ZA .

Thorsteenster commented 4 years ago

Ha, I'll have to DL the latest, I got mine last week just before the latest release. TY!

Disregard, it's the same 5.3.0 :(