search

WyLyu / UPOsHam

UPOsHam is a Python package for computing unstable periodic orbits in two degrees of freedom Hamiltonian systems
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Use standard name for requirements file #15

Closed JoshKarpel closed 5 years ago

JoshKarpel commented 5 years ago

It looks like the requirements file got renamed to requirements.dat instead of requirements.txt in https://github.com/WyLyu/UPOsHam/commit/f643659977e6255d11f9df52a3ad3808cc549663. The .txt extension is standard for this file, and people will find it surprising if it isn't named that.

(Part of https://github.com/openjournals/joss-reviews/issues/1684)

Shibabrat commented 5 years ago

26 I've reopened this pull request to point out the changes we have made.

JoshKarpel commented 5 years ago

LGTM