search

WyLyu / UPOsHam

UPOsHam is a Python package for computing unstable periodic orbits in two degrees of freedom Hamiltonian systems
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Change scripts examples #34

Closed Shibabrat closed 4 years ago

Shibabrat commented 5 years ago

This fixes #27 by moving the functions for a problem to a separate module which then gets imported by the script that applies one of the three methods (this is imported as a module from the src directory) to that problem.

Filenames of the example problems and methods have been changed. Fixes #13.

User can call the example scripts from the command line and inside python without input. Fixes #14.

Shibabrat commented 5 years ago

@JoshKarpel do you think we can merge this PR with master and see the current state of the package? I think there are a couple more fixes that we can work on: correctness and installation. But they are probably best done on top of the recent changes we have made.

JoshKarpel commented 5 years ago

@Shibabrat That sounds like a good plan to me; let's see what @dpsanders thinks before moving ahead though.

kthyng commented 4 years ago

@dpsanders Can you look at the above?

dpsanders commented 4 years ago

I'm OK with merging for now.

It still feels like there is a significant amount of code repeated that can be factored out.