search

WyattBlue / auto-editor

Auto-Editor: Efficient media analysis and rendering
https://auto-editor.com
The Unlicense
2.86k stars 418 forks source link

Better detection of s - sound. #419

Closed MilkAndBanana1 closed 7 months ago

MilkAndBanana1 commented 8 months ago

Have been using this heavily with my projects and have noticed that the audio cuts off too early in cases where a word ends with an S at the end of the phrase.

It could be a parameter where it has a threshold of how likely the end timestamp of loud has an S sound or not and if there is, lower the loud threshold until a certain point so the s sound passes through before adding the timestamp.

ErikVogelLUH commented 8 months ago

Isn't that what the margin keyword ist for?

MilkAndBanana1 commented 7 months ago

Isn't that what the margin keyword ist for?

I do have the margin fairly low so and I believe I was most likely just pushing this to a point where it's not really designed for it since this is made with manual editing still in mind. If one day I have enough knowledge to do this I have an idea of potentially having a toggle for adding some sort of phoneme detection specifically before the beginning of silences and then cross referencing it with just the regular silence trim parameters.

I believe this is probably not something the program should have since I think its best to make this a fork rather than an actual feature in this project.